Skip to content

Remove awsapi leftovers - #13712

Open
winterhazel wants to merge 2 commits into
apache:mainfrom
winterhazel:remove-awsapi
Open

winterhazel wants to merge 2 commits into
apache:mainfrom
winterhazel:remove-awsapi

Conversation

@winterhazel

Copy link
Copy Markdown
Member

Description

This PR removes a few leftovers from awsapi.

Column default_zone_id was added to account solely for the integration, and is not used anymore. API markDefaultZoneForAccount was created to set the value of this unused column.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

How Has This Been Tested?

Tests are still pending.

@codecov

codecov Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.65%. Comparing base (4f11707) to head (1996013).
⚠️ Report is 172 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #13712   +/-   ##
=========================================
  Coverage     19.65%   19.65%           
+ Complexity    19792    19790    -2     
=========================================
  Files          6368     6367    -1     
  Lines        574881   574807   -74     
  Branches      70351    70345    -6     
=========================================
- Hits         112970   112957   -13     
+ Misses       449639   449578   -61     
  Partials      12272    12272           
Flag Coverage Δ
uitests 3.41% <ø> (ø)
unittests 20.92% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland moved this from Backlog to Ready in CloudStack Testing Sep 1, 2026
@winterhazel
winterhazel marked this pull request as ready for review October 7, 2026 13:13

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

2 participants